Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pelican_comment_system: Fix element ID in cancelReply() #820

Merged
merged 1 commit into from
Dec 21, 2016

Conversation

adeverteuil
Copy link
Contributor

Please review this pull request in which I fixed a bug where the element
ID used in the jQuery expression was wrong.

@Scheirle
Copy link
Member

Nice catch.


Please also add this to the changelog pelican_comment_system/CHANGELOG.md
e.g. - Fix cancelReply [PR #820](https://github.com/getpelican/pelican-plugins/pull/820)
And while you are at it please also replace ## x.x.x – TBA with ## 1.2.1 – 2016-12-19. Thanks 😄

@adeverteuil
Copy link
Contributor Author

There you go!

@justinmayer
Copy link
Member

Looks good to me. How about you, @Scheirle?

Copy link
Member

@Scheirle Scheirle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Thanks, @adeverteuil

@justinmayer justinmayer changed the title Fix element ID in cancelReply() (pelican_comment_system) pelican_comment_system: Fix element ID in cancelReply() Dec 21, 2016
@justinmayer justinmayer merged commit 5ba46d0 into getpelican:master Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants