Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update schema to work with merging mixin schema #13

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Update schema to work with merging mixin schema #13

merged 1 commit into from
Mar 12, 2019

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Mar 12, 2019 •
edited
Loading

This updates the schema returned by the azure mixin to conform to what is expected by porter when merging mixin schema.

  • the root object is type object with properties that are actions
  • the references are all relative
  • stubbed schema are in place for unimplemented actions

This is part of #12 but doesn't fix it entirely, because for example it doesn't add in enum of allowed values for type.

@ghost ghost assigned carolynvs Mar 12, 2019
@ghost ghost added the review label Mar 12, 2019
@carolynvs carolynvs merged commit a732954 into getporter:master Mar 12, 2019
@carolynvs carolynvs deleted the fix-schema branch March 12, 2019 17:15
@ghost ghost removed the review label Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdice vdice vdice approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees

@carolynvs carolynvs

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carolynvs @vdice @carolynvs-msft