Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action.go): implement the SuppressesOutput interface #16

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

vdice
Copy link
Member

@vdice vdice commented Mar 27, 2020

  • Implements the SuppressesOutput interface

Ref getporter/porter#940

Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one small suggestion

@@ -83,6 +84,10 @@ func (s Step) GetOutputs() []builder.Output {
return outputs
}

func (s Step) SuppressesOutput() bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a line that verifies that Step implements SuppressesOutput too

Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
@vdice vdice force-pushed the feat/impl-suppress-output branch from bad6800 to c7aaaad Compare March 31, 2020 20:37
@vdice vdice merged commit 5cb02db into getporter:master Mar 31, 2020
@vdice vdice deleted the feat/impl-suppress-output branch March 31, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants