Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user agent to AWS CLI requests #34

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

clareliguori
Copy link
Contributor

@clareliguori clareliguori commented Sep 7, 2022

Setting the user agent for the AWS CLI helps provide more context in AWS CloudTrail entries about the API calls made by the Porter AWS mixin, especially where Porter might be using the same credentials used by other tools.

Example CloudTrail entry snippet for an S3 CreateBucket API call using the aws-bucket example, showing the Porter user agent:

{
    "eventVersion": "1.08",
    "eventTime": "2022-09-07T15:37:18Z",
    "eventSource": "s3.amazonaws.com",
    "eventName": "CreateBucket",
    "awsRegion": "us-east-1",
    "userAgent": "[aws-cli/2.7.29 Python/3.9.11 Linux/5.15.0-46-generic exec-env/getporter/porter getporter/aws/v0.0.0 exe/x86_64.debian.9 prompt/off command/s3api.create-bucket]",

Signed-off-by: Clare Liguori <liguori@amazon.com>
@getporterbot getporterbot added this to In Progress in Porter and Mixins Sep 7, 2022
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super helpful, thank you! 💯

@carolynvs carolynvs merged commit 504d271 into getporter:main Sep 9, 2022
Porter and Mixins automation moved this from In Progress to Done Sep 9, 2022
@carolynvs
Copy link
Member

Thanks for the PRs, @clareliguori! I would love to connect and hear about how it's going so far using Porter with AWS. I'm always looking for more ways to make the mixins more useful and work on all clouds. If you are interested in sharing your experience, my email is me@carolynvanslyck.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants