Fix publish target #45
Conversation
|
Oops, one more change is needed so hold off on reviewing. I need to make a personal access token and use it in the workflow since the default token doesn't have access to the packages repository where we upload the updated atom feed. |
|
Here is a successful publish that I ran on my fork https://github.com/carolynvs/azure-plugins/actions/runs/2378474438 https://github.com/carolynvs/azure-plugins/releases/tag/canary |
|
Here is a successful run based on a tag: https://github.com/carolynvs/azure-plugins/runs/6575444361?check_suite_focus=true https://github.com/carolynvs/azure-plugins/releases/tag/v1.0.0-beta.2 When branches are pushed to that repo, publish is skipped (we only publish canary and tagged releases using logic built into porter). |
carolynvs
force-pushed
the
gh-actions
branch
3 times, most recently
from
3ed4cee
to
d5c077f
Compare
I have converted the repository from make to mage, and from azure devops pipelines to github actions. I figured as long as I was here fixing our broken build, lets just finish moving over to where we want to be. The problem with the publish target was a few things. One there was a bug in the magefiles generatePackageFeed function, where it wasn't checking the error when calling porter to generate the atom.xml file for the feed. Porter wasn't installed, and it was quietly failing. We are now using a fixed version of the magefiles repo, and installing porter into bin before attempting to publish. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
|
Okay! This is now ready to review. I've defined a new organization secret PUBLISH_TOKEN that all the repos can use to publish binaries and the atom feed. |
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
magefile.go
Outdated
|
|
||
| // XBuildAll cross-compiles the plugin | ||
| func XBuildAll() { | ||
| rebuild, err := target.Path(filepath.Join(binDir, "dev/azure-linux-amd64"), srcDirs...) |
There was a problem hiding this comment.
Should we use target.Dir here?
There was a problem hiding this comment.
Yes, thanks I must have copied this from an older magefile in the k8s plugin repo from before your fix.
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
|
squeezes her eyes shut and presses the green button 😆 |
I have converted the repository from make to mage, and from azure devops pipelines to github actions. I figured as long as I was here fixing our broken build, lets just finish moving over to where we want to be.
The problem with the publish target was a few things. One there was a bug in the magefiles generatePackageFeed function, where it wasn't checking the error when calling porter to generate the atom.xml file for the feed. Porter wasn't installed, and it was quietly failing.
We are now using a fixed version of the magefiles repo, and installing porter into bin before attempting to publish.
🚨 I will update this PR once getporter/magefiles#13 is merged. Do not merge until its in.