Cleanup secret name before use #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
requested review from
simongdavies,
sgettys and
bdegeeter
as code owners
Azure Key Vault only allows a limited set of characters in secret names, alphanumeric with hyphens with 127 characters max. I have updated the plugin to replace any invalid characters with a hyphen before storing or retrieving. When too long, I keep as much of the key as possible and then append the md5 sum of the original key to the end. I've also added more logging so that we can track down when the value was cleaned and what the originally requested key was. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
anatbal
approved these changes
Feb 28, 2023
sgettys
reviewed
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure Key Vault only allows a limited set of characters in secret names, alphanumeric with hyphens. I have updated the plugin to replace any invalid characters with a hyphen before storing or retrieving. I've also added more logging so that we can track down when the value was cleaned and what the originally requested key was.
Fixes #51