Add support for vaultUrl in azure keyvault plugin #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatbal
requested review from
carolynvs,
simongdavies,
sgettys and
bdegeeter
as code owners
anatbal
force-pushed
the
feature/keyvault-url-param
branch
from
f349577
to
88a6fbb
Compare
3 tasks
carolynvs
requested changes
Mar 2, 2023
Signed-off-by: Anat Balzam <13421451+anatbal@users.noreply.github.com>
Signed-off-by: Anat Balzam <13421451+anatbal@users.noreply.github.com>
Signed-off-by: Anat Balzam <13421451+anatbal@users.noreply.github.com>
Co-authored-by: Carolyn Van Slyck <me@carolynvanslyck.com> Signed-off-by: Anat Balzam <13421451+anatbal@users.noreply.github.com>
anatbal
force-pushed
the
feature/keyvault-url-param
branch
from
2816161
to
a37b6f2
Compare
anatbal
requested review from
carolynvs
and removed request for
simongdavies,
sgettys and
bdegeeter
|
@carolynvs Thanks! I fixed the docs with your suggestion |
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
|
Your fix is now available in the v1.2.0 release: https://github.com/getporter/azure-plugins/releases/tag/v1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Azure Key Vault plugin enforces that the URL of the vault must follow the format of "https://%s.vault.azure.net".
A new configuration parameter called "vaultURL" has been added in this pull request. This new parameter allows for the possibility of other suffixes to be used, thereby enabling support for multiple clouds, such as the government cloud.
It's worth noting that the "vault" parameter will still be available, but its value will be overridden by the "vaultURL" parameter if exists.