Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all build scripts to mage #23

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Jul 19, 2021

Porter defines reusable targets for mixins in mage/mixins. This PR
demonstrates how each mixin should be updated to migrate from Makefile
to magefile.go

In addition to moving to mage a bit of cleanup was also done:

  • Reference porter v1 prerelease
  • Use go:embed instead of packr
  • Use Go 1.16
  • Use yaml v3 library to match Porter

Porter defines reusable targets for mixins in mage/mixins. This PR
demonstrates how each mixin should be updated to migrate from Makefile
to magefile.go

In addition to moving to mage a bit of cleanup was also done:
* Reference porter v1 prerelease
* Use go:embed instead of packr
* Use Go 1.16
* Use yaml v3 library to match Porter

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs marked this pull request as ready for review January 7, 2022 21:12
@carolynvs carolynvs requested a review from vdice January 7, 2022 21:12
@carolynvs carolynvs merged commit 919e54b into getporter:main Jan 10, 2022
@carolynvs carolynvs deleted the mage-migration branch January 10, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants