Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

feat(build.go): restrict to client version of v2.x.x #68

Merged
merged 1 commit into from
Apr 15, 2020
Merged

feat(build.go): restrict to client version of v2.x.x #68

merged 1 commit into from
Apr 15, 2020

Conversation

vdice
Copy link
Member

@vdice vdice commented Apr 15, 2020 •
edited
Loading

  • adds functionality to verify the client version supplied via mixin config satisfies semver constraints

Depends on getporter/porter#989 for build error to actually stop build.

Closes #67

@vdice
feat(build.go): restrict to client version of v2.x.x
af3098b 
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
@vdice vdice requested review from MChorfa and carolynvs April 15, 2020 18:04
carolynvs
carolynvs approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MChorfa
MChorfa approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@MChorfa MChorfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@vdice vdice merged commit 3522203 into getporter:master Apr 15, 2020
@vdice vdice deleted the feat/restrict-to-v2 branch April 15, 2020 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carolynvs carolynvs carolynvs approved these changes

@MChorfa MChorfa MChorfa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validation that supplied Helm client version is v2.x.x
3 participants
@vdice @MChorfa @carolynvs