Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update staticcheck to be used with gov1.20 #26

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

troy0820
Copy link
Member

@troy0820 troy0820 commented Jul 3, 2023

Doing go install honnef.co/go/tools/cmd/staticcheck@latest gives you staticcheck 2023.1.3 (v0.4.3). This works with gov1.20

  • Update version for staticcheck

Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@troy0820 troy0820 force-pushed the troy0820/update-staticcheck branch from f69113c to 0911728 Compare July 3, 2023 19:09
@troy0820
Copy link
Member Author

troy0820 commented Jul 3, 2023

After this is done, we have to update getporter/porter's deps for this repo so it has the latest. This will move it to gov1.20 and pass the gates preventing it from resolving the staticcheck issue.

Also, because this is shared, this may need to be updated in several places. (The go.mod entry)

@schristoff schristoff merged commit 0be5afe into getporter:main Jul 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants