Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove errors from staticcheck and go vet with gov1.20 #27

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

troy0820
Copy link
Member

@troy0820 troy0820 commented Jul 3, 2023

With the addition of the new staticcheck version added in the last release, the check(s) performed on this repository produced a number of errors. Within those errors it was noted that there were several mage targets that could be utilized to ensure the integrity of this repository.

  • Add vet
  • Add lint/staticcheck
  • Fix errors with staticcheck and go vet for go1.20
  • Updated github workflow

@troy0820 troy0820 force-pushed the troy0820/staticcheck-errors branch from ce3d607 to 8279b0d Compare July 3, 2023 21:37
…s with staticcheck/lint/vet

Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@troy0820 troy0820 force-pushed the troy0820/staticcheck-errors branch from 8279b0d to f288fd1 Compare July 3, 2023 21:41
with:
go-version: 1.18
go-version-file: go.mod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this

@schristoff schristoff merged commit 9683865 into getporter:main Jul 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants