Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XBuildAll expects to publish a mixin #6

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

bdegeeter
Copy link
Contributor

@bdegeeter bdegeeter commented Apr 7, 2022

Fixes #4

Fixed another issue with EnsureKind and kind outside of $GOPATH/bin. I can break that out to another issue if needed.

Signed-off-by: Brian DeGeeter b.degeeter@f5.com

Fixes getporter#4

Signed-off-by: Brian DeGeeter <b.degeeter@f5.com>
tools/install.go Outdated Show resolved Hide resolved
Fixes getporter#4

Signed-off-by: Brian DeGeeter <b.degeeter@f5.com>
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! :shipit:

@carolynvs
Copy link
Member

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@carolynvs
Copy link
Member

oops, I forgot that I only enabled running the github action for PR forks in #7. Tests are passing locally.

@carolynvs carolynvs merged commit dfcc01a into getporter:main Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XBuildAll expects to publish a mixin
2 participants