Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image pull secrets to AgentConfig #68

Closed
carolynvs opened this issue Feb 10, 2022 · 2 comments · Fixed by #120
Closed

Add image pull secrets to AgentConfig #68

carolynvs opened this issue Feb 10, 2022 · 2 comments · Fixed by #120
Assignees
@bdegeeter
Labels
1 - 🍫 Eat chocolate _after_ emergency donuts
Projects
Porter and Mixins
Milestone
v1.1

Comments

@carolynvs
Copy link
Member

Allow pulling a bundle from a private registry and running it with the operator:

  1. Add ImagePullSecret to the AgentConfig
  2. Populate ImagePullSecret on the porter agent job.
  3. ??? I think porter will need to be modified to grab the pull secret from the environment, or we need to pass it explicitly into Porter so that it can use it when downloading the bundle.
  4. Edit the k8s driver in cnab-go to look for and set the image pull secret set by the operator on the invocation image job.
@carolynvs carolynvs added this to Inbox in Porter and Mixins via automation Feb 10, 2022
@carolynvs carolynvs added the 2 - 🍕 Pizza should be eaten daily label Feb 10, 2022
@carolynvs carolynvs added this to the v1 milestone Feb 10, 2022
@carolynvs
Copy link
Member Author

We may be able to simplify some of this by using the service accounts image pull secrets

https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/

Then we'd just have to worry about getting that passed to the porter cli so it uses it to pull the bundle definition.

@carolynvs carolynvs added 1 - 🍫 Eat chocolate _after_ emergency donuts and removed 2 - 🍕 Pizza should be eaten daily labels Sep 6, 2022
@carolynvs carolynvs mentioned this issue Sep 6, 2022
Closed
@carolynvs
Copy link
Member Author

Here is the associated issue in Porter: getporter/porter#2339

bdegeeter added a commit to bdegeeter/operator that referenced this issue Sep 12, 2022
@bdegeeter
Add image pull secrets to AgentConfig
80bfef1 
Fixes getporter#68

Signed-off-by: Brian DeGeeter <76455484+bdegeeter@users.noreply.github.com>
@bdegeeter bdegeeter self-assigned this Sep 13, 2022
This was referenced Sep 14, 2022
Merged
Open
carolynvs pushed a commit that referenced this issue Oct 21, 2022
@bdegeeter
feat: support for bundle installation from private registries (#120)
1af4457 
* Add image pull secrets to AgentConfig
Fixes #68

Signed-off-by: Brian DeGeeter <76455484+bdegeeter@users.noreply.github.com>
Signed-off-by: Steven Gettys <s.gettys@f5.com>
Co-authored-by: Steven Gettys <s.gettys@f5.com>
Co-authored-by: Steven Gettys <76455484+bdegeeter@users.noreply.github.com>
Porter and Mixins automation moved this from Inbox to Done Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdegeeter bdegeeter

Labels
1 - 🍫 Eat chocolate _after_ emergency donuts
Projects
Porter and Mixins
  
Done
Upcoming Releases
Status: Done
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

feat: support for bundle installation from private registries bdegeeter/operator
2 participants
@carolynvs @bdegeeter