167 plugin volume not about to be mounted into agent action job on aks

[sgettys]

What does this change

Added ability to specify storage class name for volumes created by the Agent Config controller so that a proper storage class can be selected that supports the required capabilities

What issue does it fix

Closes #167

Notes for the reviewer

Tested this in both KinD and AKS. Should extend the integration tests for the operator to test in all supported clouds

Checklist

• Did you write tests?
• Did you write documentation?
• Did you make any API changes? Update the corresponding API documentation.

[sgettys]

Just read the access mode descriptions and readwriteonce won't work since it can't be held by multiple nodes. Going to test out readwritemany

[carolynvs]

@sgettys I know we spoke more after you opened this PR about changing which storage class we are using. Is this PR ready to review or do you want me to wait for the full solution?

[sgettys]

@sgettys I know we spoke more after you opened this PR about changing which storage class we are using. Is this PR ready to review or do you want me to wait for the full solution?

It will be ready today, just need to roll back access modes to what was there previously and add some documentation around storage classes

[codecov]

Codecov Report

Merging #168 (7842c04) into main (aee5979) will decrease coverage by 0.32%.
The diff coverage is 38.46%.

❗ Current head 7842c04 differs from pull request most recent head 31bb110. Consider uploading reports for the commit 31bb110 to get more accurate results

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   76.58%   76.26%   -0.32%     
==========================================
  Files          13       13              
  Lines        1550     1563      +13     
==========================================
+ Hits         1187     1192       +5     
- Misses        232      236       +4     
- Partials      131      135       +4     

Flag	Coverage Δ
unit-tests	76.26% <38.46%> (-0.32%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
controllers/agentaction_controller.go	82.12% <33.33%> (-0.32%)	⬇️
controllers/agentconfig_controller.go	71.53% <33.33%> (-0.86%)	⬇️
api/v1/agentconfig_types.go	70.22% <100.00%> (+0.22%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sgettys]

@carolynvs this is ready for review

[carolynvs]

LGTM just found a small typo

[carolynvs]

This matrix is really helpful! 👍

[hemantkathuria]

@sgettys - I am facing the same issue when I am trying to install a package on AKS, getting the volume mount error. I have installed 0.8.2 version of Porter Operator in my AKS cluster.
I am a first time user of porter. Could you please tell me what do i need to change in AgentConfig? I tried adding storageClassName: managed to default agentconfig but no luck. If you can tell me the right steps, it will be very helpful.

[sgettys]

@sgettys - I am facing the same issue when I am trying to install a package on AKS, getting the volume mount error. I have installed 0.8.2 version of Porter Operator in my AKS cluster. I am a first time user of porter. Could you please tell me what do i need to change in AgentConfig? I tried adding storageClassName: managed to default agentconfig but no luck. If you can tell me the right steps, it will be very helpful.
@hemantkathuria
Did you follow the directions here? https://github.com/getporter/operator/blob/main/docs/content/administrators/configure-porter-agent.md

For AKS the storageClassName should be azureblob-nfs-premium not default. You can also list all of the built in storage classes in your cluster with kubectl get storageclass and make sure the azureblob-nfs-premium is listed. Here’s some docs about AKS and storage classes
https://learn.microsoft.com/en-us/azure/aks/concepts-storage

[hemantkathuria]

Thank you for the quick response @sgettys. I did not look at the article.

I went ahead and edited the default agentconfig itself. But i am still getting the same error. Do i need to create a custom one? If yes how i do i refer the same in my installation?

Normal Scheduled 14m default-scheduler Successfully assigned unifieddeployment/azuredep-15-trdxh-rsvkf-2dwp2 to aks-agentpool-28266374-vmss000001
Normal SuccessfulAttachVolume 14m attachdetach-controller AttachVolume.Attach succeeded for volume "pvc-54b60455-3a8b-4794-b421-3e449e26a3b1"
Warning FailedMount 6m9s (x2 over 8m24s) kubelet Unable to attach or mount volumes: unmounted volumes=[porter-plugins], unattached volumes=[kube-api-access-q95w9 porter-shared porter-config porter-workdir porter-plugins]: timed out waiting for the condition
Warning FailedMount 3m51s (x2 over 12m) kubelet Unable to attach or mount volumes: unmounted volumes=[porter-plugins], unattached volumes=[porter-config porter-workdir porter-plugins kube-api-access-q95w9 porter-shared]: timed out waiting for the condition
Warning FailedMount 97s (x2 over 10m) kubelet Unable to attach or mount volumes: unmounted volumes=[porter-plugins], unattached volumes=[porter-shared porter-config porter-workdir porter-plugins kube-api-access-q95w9]: timed out waiting for the condition
Warning FailedAttachVolume 86s (x14 over 13m) attachdetach-controller AttachVolume.Attach failed for volume "pvc-4a56288b-f82c-4b70-a5d6-1d036d51820f" : rpc error: code = InvalidArgument desc = Volume capability not supported