-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
167 plugin volume not about to be mounted into agent action job on aks #168
167 plugin volume not about to be mounted into agent action job on aks #168
Conversation
Just read the access mode descriptions and readwriteonce won't work since it can't be held by multiple nodes. Going to test out readwritemany |
@sgettys I know we spoke more after you opened this PR about changing which storage class we are using. Is this PR ready to review or do you want me to wait for the full solution? |
It will be ready today, just need to roll back access modes to what was there previously and add some documentation around storage classes |
Codecov Report
@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 76.58% 76.26% -0.32%
==========================================
Files 13 13
Lines 1550 1563 +13
==========================================
+ Hits 1187 1192 +5
- Misses 232 236 +4
- Partials 131 135 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9ac9dfe
to
d5894ce
Compare
@carolynvs this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just found a small typo
[csistoragecapacity notation]: https://kubernetes.io/docs/reference/kubernetes-api/config-and-storage-resources/csi-storage-capacity-v1/ | ||
|
||
### StorageClassName Cluster Compatability Matrix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This matrix is really helpful! 👍
… on the plugin volume fix: Added storage class name to agent config to allow for controller to select appropriate storage class when creating volumes Signed-off-by: Steven Gettys <s.gettys@f5.com>
7842c04
to
31bb110
Compare
@sgettys - I am facing the same issue when I am trying to install a package on AKS, getting the volume mount error. I have installed 0.8.2 version of Porter Operator in my AKS cluster. |
For AKS the storageClassName should be azureblob-nfs-premium not default. You can also list all of the built in storage classes in your cluster with kubectl get storageclass and make sure the azureblob-nfs-premium is listed. Here’s some docs about AKS and storage classes |
Thank you for the quick response @sgettys. I did not look at the article. I went ahead and edited the default agentconfig itself. But i am still getting the same error. Do i need to create a custom one? If yes how i do i refer the same in my installation? Normal Scheduled 14m default-scheduler Successfully assigned unifieddeployment/azuredep-15-trdxh-rsvkf-2dwp2 to aks-agentpool-28266374-vmss000001 |
What does this change
Added ability to specify storage class name for volumes created by the Agent Config controller so that a proper storage class can be selected that supports the required capabilities
What issue does it fix
Closes #167
Notes for the reviewer
Tested this in both KinD and AKS. Should extend the integration tests for the operator to test in all supported clouds
Checklist