-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting build args during porter build #1124
Labels
Comments
If no one is working on this, I'd take a crack at it |
Perfect! All yours, let us know if you have any questions. |
Here's where we set the build args for docker during the |
Thanks @carolynvs !! |
@carolynvs Do you have any plan to add this feature ? |
Closed in #1769 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sometimes a bundle needs to configure something during build, for example use a corporate proxy while building the bundle, but it doesn't want those values hard coded into the image because it will be used in many environments.
porter build --arg PROXY=https://example.com/proxy
Then the author can use the argument passed (see below). It is up to the author to define and use the arg in the Dockerfile, this feature should not edit the Dockerfile.
Related #927
The text was updated successfully, but these errors were encountered: