-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support buildkit flags #1769
Comments
From @MChorfa https://www.youtube.com/watch?v=0iN4dJB3OLk buildx is a Docker CLI plugin for extended build capabilities with BuildKit. BuildKit is a toolkit for converting source code to build artifacts in an efficient, expressive and repeatable manner. xx - Dockerfile cross-compilation helpers Cross-platform emulator collection distributed with Docker images. |
This adds support for the following docker flags: --build-arg: Pass build arguments that can be used in the template dockerfile --ssh: Provide a ssh configuration to the container while building --secret: Provide a secret to the container while building Closes getporter#1769 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
This adds support for the following docker flags: --build-arg: Pass build arguments that can be used in the template dockerfile --ssh: Provide a ssh configuration to the container while building --secret: Provide a secret to the container while building Closes getporter#1769 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
This adds support for the following docker flags: --build-arg: Pass build arguments that can be used in the template dockerfile --ssh: Provide a ssh configuration to the container while building --secret: Provide a secret to the container while building --no-cache: Build the image and do not use cached layers. It also fixes how we call the docker buildx plugin so that user configuration, such as a proxy, is used. After upgrading to a new version of buildx, I was also able to pick up a fix for pretty printing the progress to stderr, while capturing the plaintext output to the logs. Closes getporter#1769 Closes getporter#1941 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
This adds support for the following docker flags: --build-arg: Pass build arguments that can be used in the template dockerfile --ssh: Provide a ssh configuration to the container while building --secret: Provide a secret to the container while building --no-cache: Build the image and do not use cached layers. It also fixes how we call the docker buildx plugin so that user configuration, such as a proxy, is used. After upgrading to a new version of buildx, I was also able to pick up a fix for pretty printing the progress to stderr, while capturing the plaintext output to the logs. Closes getporter#1769 Closes getporter#1941 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
This adds support for the following docker flags: --build-arg: Pass build arguments that can be used in the template dockerfile --ssh: Provide a ssh configuration to the container while building --secret: Provide a secret to the container while building --no-cache: Build the image and do not use cached layers. It also fixes how we call the docker buildx plugin so that user configuration, such as a proxy, is used. After upgrading to a new version of buildx, I was also able to pick up a fix for pretty printing the progress to stderr, while capturing the plaintext output to the logs. Closes getporter#1769 Closes getporter#1941 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
This adds support for the following docker flags: --build-arg: Pass build arguments that can be used in the template dockerfile --ssh: Provide a ssh configuration to the container while building --secret: Provide a secret to the container while building --no-cache: Build the image and do not use cached layers. It also fixes how we call the docker buildx plugin so that user configuration, such as a proxy, is used. After upgrading to a new version of buildx, I was also able to pick up a fix for pretty printing the progress to stderr, while capturing the plaintext output to the logs. Closes getporter#1769 Closes getporter#1941 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
…#1999) * Support additional docker build flags This adds support for the following docker flags: --build-arg: Pass build arguments that can be used in the template dockerfile --ssh: Provide a ssh configuration to the container while building --secret: Provide a secret to the container while building --no-cache: Build the image and do not use cached layers. It also fixes how we call the docker buildx plugin so that user configuration, such as a proxy, is used. After upgrading to a new version of buildx, I was also able to pick up a fix for pretty printing the progress to stderr, while capturing the plaintext output to the logs. Closes #1769 Closes #1941 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> * Remove experimental flag for build drivers Default to buildkit only and remove the docker build driver Keep the build driver config option, in case we ever get creative in the future Closes #1954 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> * Default dockerfile syntax to 1.4.0 If a template that was previously written for legacy docker is used now that we only support buildkit, use dockerfile syntax 1.4.0 and prepend that to their template so that when we inject things like `COPY --link` their bundle still builds. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> * Code cleanup Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> * Document new ShouldLog function Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Closed by #1999. |
When I added buildkit support, I didn't expose all the necessary flags that docker build has so that the user can pass in information to the build during
porter build
that buildkit supports. When we build a bundle that uses buildkit in the template, we should support passing in extra arguments such as ssh, mounts and secrets.https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/syntax.md
The scenarios we want to support are:
The text was updated successfully, but these errors were encountered: