Use docker system config #1941
Assignees
Labels
2 - 🍕
Pizza should be eaten daily
gap
We missed a spot
user experience 🌈💖
Make it easier for everyone to use Porter
Milestone
Comments
carolynvs
added
2 - 🍕
carolynvs
added a commit
to carolynvs/porter
that referenced
this issue
Apr 1, 2022
This adds support for the following docker flags: --build-arg: Pass build arguments that can be used in the template dockerfile --ssh: Provide a ssh configuration to the container while building --secret: Provide a secret to the container while building --no-cache: Build the image and do not use cached layers. It also fixes how we call the docker buildx plugin so that user configuration, such as a proxy, is used. After upgrading to a new version of buildx, I was also able to pick up a fix for pretty printing the progress to stderr, while capturing the plaintext output to the logs. Closes getporter#1769 Closes getporter#1941 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
added a commit
to carolynvs/porter
that referenced
this issue
Apr 1, 2022
This adds support for the following docker flags: --build-arg: Pass build arguments that can be used in the template dockerfile --ssh: Provide a ssh configuration to the container while building --secret: Provide a secret to the container while building --no-cache: Build the image and do not use cached layers. It also fixes how we call the docker buildx plugin so that user configuration, such as a proxy, is used. After upgrading to a new version of buildx, I was also able to pick up a fix for pretty printing the progress to stderr, while capturing the plaintext output to the logs. Closes getporter#1769 Closes getporter#1941 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
added a commit
to carolynvs/porter
that referenced
this issue
Apr 4, 2022
This adds support for the following docker flags: --build-arg: Pass build arguments that can be used in the template dockerfile --ssh: Provide a ssh configuration to the container while building --secret: Provide a secret to the container while building --no-cache: Build the image and do not use cached layers. It also fixes how we call the docker buildx plugin so that user configuration, such as a proxy, is used. After upgrading to a new version of buildx, I was also able to pick up a fix for pretty printing the progress to stderr, while capturing the plaintext output to the logs. Closes getporter#1769 Closes getporter#1941 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
4 tasks
carolynvs
added a commit
to carolynvs/porter
that referenced
this issue
Apr 4, 2022
This adds support for the following docker flags: --build-arg: Pass build arguments that can be used in the template dockerfile --ssh: Provide a ssh configuration to the container while building --secret: Provide a secret to the container while building --no-cache: Build the image and do not use cached layers. It also fixes how we call the docker buildx plugin so that user configuration, such as a proxy, is used. After upgrading to a new version of buildx, I was also able to pick up a fix for pretty printing the progress to stderr, while capturing the plaintext output to the logs. Closes getporter#1769 Closes getporter#1941 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
added a commit
that referenced
this issue
Apr 5, 2022
…#1999) * Support additional docker build flags This adds support for the following docker flags: --build-arg: Pass build arguments that can be used in the template dockerfile --ssh: Provide a ssh configuration to the container while building --secret: Provide a secret to the container while building --no-cache: Build the image and do not use cached layers. It also fixes how we call the docker buildx plugin so that user configuration, such as a proxy, is used. After upgrading to a new version of buildx, I was also able to pick up a fix for pretty printing the progress to stderr, while capturing the plaintext output to the logs. Closes #1769 Closes #1941 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> * Remove experimental flag for build drivers Default to buildkit only and remove the docker build driver Keep the build driver config option, in case we ever get creative in the future Closes #1954 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> * Default dockerfile syntax to 1.4.0 If a template that was previously written for legacy docker is used now that we only support buildkit, use dockerfile syntax 1.4.0 and prepend that to their template so that when we inject things like `COPY --link` their bundle still builds. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> * Code cleanup Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> * Document new ShouldLog function Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
|
Closed by #1999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have seen a few issues with build, publish and "pull" where the user has customizations such as a proxy or custom certificate that works with Docker but not with Porter. Let's review how we are loading the docker configuration so that it includes docker's configuration file.
The text was updated successfully, but these errors were encountered: