Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically call the host secrets plugin #2223

Closed
carolynvs opened this issue Jul 5, 2022 · 0 comments · Fixed by #3155
Closed

Automatically call the host secrets plugin #2223

carolynvs opened this issue Jul 5, 2022 · 0 comments · Fixed by #3155
Assignees
Labels
2 - 🍕 Pizza should be eaten daily tech debt 💸 Make it easier to develop Porter

Comments

@carolynvs
Copy link
Member

Right now when Porter resolves values for a Parameter/Credential set, we call the secrets plugin for everything, even those where the source is not secret, like env, path, etc. Those other sources are all handled by the host secrets plugin and we shouldn't require every custom secrets plugin to handle figuring out when to call back to the host secrets plugin.

When resolving a ps/cs, Porter should check the source, and if it is a source that is associated with the host secrets plugin: command, value, env, path, then Porter should resolve it directly from the host secrets plugin. The secrets plugin should only be called for other sources. Right now the only other source is secret, but if in the future we add more source types, then we should also allow custom plugins to handle that if they choose.

@carolynvs carolynvs added 2 - 🍕 Pizza should be eaten daily tech debt 💸 Make it easier to develop Porter labels Jul 5, 2022
@getporterbot getporterbot added this to Inbox in Porter and Mixins Jul 5, 2022
@carolynvs carolynvs moved this from Inbox to Backlog in Porter and Mixins Jul 5, 2022
@kichristensen kichristensen self-assigned this Jun 11, 2024
Porter and Mixins automation moved this from Backlog to Done Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - 🍕 Pizza should be eaten daily tech debt 💸 Make it easier to develop Porter
Development

Successfully merging a pull request may close this issue.

2 participants