Call host secrets plugin directly when resolving secrets #3155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not require all secret plugins to call the host secrets plugin for non secret values. Instead we should call the host secrets plugin directly. Signed-off-by: Kim Christensen <kimworking@gmail.com>
kichristensen
force-pushed
the
callHostSecretsPlugin
branch
from
fc8ddd2
to
59a86c9
Compare
kichristensen
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
We should not require all secret plugins to call the host secrets plugin for non secret values. Instead we should call the host secrets plugin directly.
What issue does it fix
Closes #2223
Notes for the reviewer
No integration test was added, as there already is an existing integration test covering the case
porter/tests/integration/install_test.go
Line 44 in 75d49d2
Checklist