-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call host secrets plugin directly when resolving secrets #3155
Merged
kichristensen
merged 7 commits into
getporter:main
from
kichristensen:callHostSecretsPlugin
Aug 23, 2024
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
59a86c9
Call host secrets plugin directly when resolving secrets
kichristensen 46dd227
Merge branch 'main' into callHostSecretsPlugin
schristoff 434693f
Merge branch 'main' into callHostSecretsPlugin
kichristensen e91a74d
Merge branch 'main' into callHostSecretsPlugin
kichristensen f9f58a1
Merge branch 'main' into callHostSecretsPlugin
kichristensen 855a150
Merge branch 'main' into callHostSecretsPlugin
kichristensen ecfb471
Merge branch 'main' into callHostSecretsPlugin
kichristensen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ package storage | |
import ( | ||
"get.porter.sh/porter/pkg/config" | ||
"get.porter.sh/porter/pkg/storage/plugins/testplugin" | ||
"github.com/cnabio/cnab-go/secrets/host" | ||
) | ||
|
||
var _ Store = TestStore{} | ||
|
@@ -23,3 +24,7 @@ func NewTestStore(tc *config.TestConfig) TestStore { | |
func (s TestStore) Close() error { | ||
return s.testPlugin.Close() | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should comment on what this logic is reasoning about |
||
func isHandledByHostPlugin(strategy string) bool { | ||
return strategy == host.SourceCommand || strategy == host.SourceEnv || strategy == host.SourcePath || strategy == host.SourceValue | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we could make a testcontext and pass that in here, but we don't have to (the func is like
NewPorterTestContext
orNewTestContext
?)