Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Parameters struct to support CNAB 1.0 changes #439

Closed
jeremyrickard opened this issue Jul 3, 2019 · 3 comments · Fixed by #476
Closed

Update Parameters struct to support CNAB 1.0 changes #439

jeremyrickard opened this issue Jul 3, 2019 · 3 comments · Fixed by #476
Assignees
Milestone

Comments

@jeremyrickard
Copy link
Contributor

In addition to the schema elements in a bundle.json, a Porter user should be able to use the "applyTo" specification to say that a parameter applies to only certain cnab actions, upgrade and uninstall, for example.

@carolynvs carolynvs added this to the CNAB 1.0 milestone Jul 17, 2019
@carolynvs
Copy link
Member

I just ran into this during uninstall. When no parameters are specified vs. any parameters specified, this triggers different logic in duffle to validate parameters. When a parameter is required, right now it's required for all actions (including uninstall). So once you specify a parameter, like --debug, this triggers other required parameters to be enforced when previously they were not. Which is sketchy logic all by itself...

Having applyTo would let us define a required parameter and have it only apply to install, not uninstall.

@vdice
Copy link
Member

vdice commented Jul 18, 2019

We may want to update this ticket to also add support for the Immutable (bool) field of the Parameters spec as well (if we aren't already tracking.)

I'm working on fixing #449 (and adding in missing Credentials and Parameters sections) but will omit ApplyTo (and Immutable) from Parameters until implemented (in this ticket).

@carolynvs carolynvs changed the title Porter should support the "applyTo" attribute for Parameters Update Parameters struct to support CNAB 1.0 changes Jul 19, 2019
@vdice vdice self-assigned this Jul 23, 2019
@vdice
Copy link
Member

vdice commented Jul 24, 2019

Created #476 to address this issue -- left out implementing Immutable as it seems there is momentum to remove from the spec prior to 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants