Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outputs schema is incomplete #449

Closed
carolynvs opened this issue Jul 12, 2019 · 1 comment · Fixed by #462
Closed

Outputs schema is incomplete #449

carolynvs opened this issue Jul 12, 2019 · 1 comment · Fixed by #462
Assignees
@vdice
Labels
1 - 🍫 Eat chocolate _after_ emergency donuts gap We missed a spot
Milestone
CNAB 1.0

Comments

@carolynvs
Copy link
Member

The schema for outputs isn't complete and needs to be filled in:

https://github.com/deislabs/porter/blob/a7a0d70d1953447fb0e718ca764940e2ecfc0d3a/pkg/porter/templates/schema.json#L42-L45
@carolynvs carolynvs added gap We missed a spot 1 - 🍫 Eat chocolate _after_ emergency donuts labels Jul 12, 2019
@carolynvs carolynvs added this to the CNAB 1.0 milestone Jul 12, 2019
@jeremyrickard
Copy link
Contributor

We also need a parameters and a credentials definition in here I think?

@vdice vdice self-assigned this Jul 18, 2019
This was referenced Jul 18, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vdice vdice

Labels
1 - 🍫 Eat chocolate _after_ emergency donuts gap We missed a spot
Projects
None yet
Milestone
CNAB 1.0
Development

Successfully merging a pull request may close this issue.

feat(schema.json): update manifest schema vdice/porter
3 participants
@carolynvs @vdice @jeremyrickard