Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(schema.json): update manifest schema #462

Merged
merged 1 commit into from
Jul 22, 2019
Merged

feat(schema.json): update manifest schema #462

merged 1 commit into from
Jul 22, 2019

Conversation

vdice
Copy link
Member

@vdice vdice commented Jul 18, 2019

  • Updates Porter's manifest schema to add credentials, outputs and parameters and their corresponding definitions

Closes #449

@vdice vdice requested a review from carolynvs July 18, 2019 21:52
carolynvs
carolynvs approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I'd like to see that one change to be consistent with how we define top level properties in the schema. 👍

@carolynvs carolynvs merged commit f7210cc into getporter:master Jul 22, 2019
@vdice vdice deleted the feat/update-manifest-schema branch July 22, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolynvs carolynvs carolynvs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outputs schema is incomplete
2 participants
@vdice @carolynvs