Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix non-string yaml keys of flags causing panic #1223

Merged
merged 2 commits into from
Aug 26, 2020
Merged

🐛 Fix non-string yaml keys of flags causing panic #1223

merged 2 commits into from
Aug 26, 2020

Conversation

dev-drprasad
Copy link
Contributor

What does this change

Fixes non strings yaml keys of flags causing panic

What issue does it fix

Closes #1215

Notes for the reviewer

Checklist

  • Unit Tests
  • Documentation - N/A
  • Schema (porter.yaml) - N/A

@dev-drprasad dev-drprasad changed the title 🐛 Fix non strings yaml keys of flags causing panic 🐛 Fix non-string yaml keys of flags causing panic Aug 22, 2020
carolynvs
carolynvs approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I didn't realize that go-yaml was this smart. 💯

@carolynvs carolynvs merged commit e0c1d5e into getporter:main Aug 26, 2020
@carolynvs carolynvs self-assigned this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolynvs carolynvs carolynvs approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@vdice vdice Awaiting requested review from vdice

Assignees

@carolynvs carolynvs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bool flag caused a panic
2 participants
@dev-drprasad @carolynvs