Added Porter Mixins and Plugins details in Readme.md #1640
Conversation
DARK-art108
requested review from
carolynvs,
jeremyrickard and
vdice
as code owners
DARK-art108
force-pushed
the
docs/DARK-art108/Readme
branch
from
d4a5a28 to
fb04226
Compare
|
@carolynvs Please take a look at it! :) |
README.md
Outdated
| | Platform | Supported? | | ||
| | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :---------: | | ||
| | <img src="docs\static\images\mixins\docker_icon.png" width="20" height="20" vertical-align="middle" /> [Docker](https://porter.sh/mixins/docker/) | ✔️ | | ||
| | <img src="docs\static\images\mixins\docker-compose.png" width="20" height="20" vertical-align="middle" /> [Docker-Compose](https://porter.sh/mixins/docker-compose/) | ✔️ | |
There was a problem hiding this comment.
Looks like you forgot the leading whitespace on the first row in the table (for Docker and hashicorp below). Can you either remove the leading whitespace on the other rows, or add the same whitespace to the first row of each table?
There was a problem hiding this comment.
Hello @carolynvs, I am not getting leading whitespaces, can you be more clear!
There was a problem hiding this comment.
On line 24, in the first table cell you have this
<img src="docs\static\images\mixins\docker_icon.png" ...
On line 25 (and the remaining cells in the table), you have the HTML whitespace character (stands for non-breaking space) in front of the image, which shifts the image over to the right when the page is displayed.
<img src="docs\static\images\mixins\docker-compose.png"
If those whitespace characters were unintentional, would you please remove them from both tables?
There was a problem hiding this comment.
@carolynvs I have pushed the changes do take a look at it!
DARK-art108
force-pushed
the
docs/DARK-art108/Readme
branch
2 times, most recently
from
eefd569 to
3789a5c
Compare
Signed-off-by: Ritesh Yadav <daydreamingguy941@gmail.com>
DARK-art108
force-pushed
the
docs/DARK-art108/Readme
branch
from
3789a5c to
8b5a1b0
Compare
What does this change
Added all the available Porter Mixins and Plugins in a Tabular format in Readme.md
What issue does it fix
Closes #1624
Notes for the reviewer
Put any questions or notes for the reviewer here.
Checklist
If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇♀️