Skip publish for v1 canary and latest #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was running into conflict with how we detect versions with the other tagging scheme (v1-latest would get flagged as a real release). Switching the order so that it's latest-v1 will help avoid a bunch of false positives and workarounds. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Do not publish latest-* or canary-* for simplicity Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
I accidentally used xplat.FileExt which isn't helpful because the builds cross-compiled, so the windows binary was missing the .exe extension. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
vdice
approved these changes
Jun 15, 2021
carolynvs
added a commit
to carolynvs/porter
that referenced
this pull request
Jun 15, 2021
* Change permalinks to prefix with canary/latest I was running into conflict with how we detect versions with the other tagging scheme (v1-latest would get flagged as a real release). Switching the order so that it's latest-v1 will help avoid a bunch of false positives and workarounds. * Only publish v*, latest and canary Do not publish latest-* or canary-* for simplicity Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
added a commit
to carolynvs/porter
that referenced
this pull request
Jun 15, 2021
* Change permalinks to prefix with canary/latest I was running into conflict with how we detect versions with the other tagging scheme (v1-latest would get flagged as a real release). Switching the order so that it's latest-v1 will help avoid a bunch of false positives and workarounds. * Only publish v*, latest and canary Do not publish latest-* or canary-* for simplicity Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
What issue does it fix
broken build and other shenanigans
Notes for the reviewer
N/A
Checklist