Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go.mod entry for jsonschema #1655

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Jul 2, 2021

What does this change

I submitted my fix upstream to the jsonschema library and had to rebase so the reference to the PR in our go.mod file changed.

What issue does it fix

Builds of porter where the local go mod cache is empty and doesn't have cached the old branch sha. After this is merged I'll immediately merge into v1.

Notes for the reviewer

N/A

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

@carolynvs carolynvs mentioned this pull request Jul 2, 2021
3 tasks
@carolynvs carolynvs marked this pull request as ready for review July 2, 2021 15:12
@carolynvs carolynvs changed the base branch from release/v1 to main July 2, 2021 15:24
I submitted my fix upstream and had to rebase so the reference to the PR
in our go.mod file changed.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs merged commit 1723384 into getporter:main Jul 2, 2021
@carolynvs carolynvs deleted the fix-go-mod branch July 2, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants