Fix applyTo check for outputs in porter explain #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have consolidated the logic for checking if a scoped item: parameter, credential or output, should be included in the output of explain to avoid errors when duplicating the logic for each one. There was also a copy/paste of the appliesTo logic for ParameterDefinition (our def of a parameter in the porter manifest) that I updated to implement Scoped so that we can hopefully avoid more problems with this type of check. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
fix-explain-outputs
branch
from
c28213b to
a2837ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
I have consolidated the logic for checking if a scoped item: parameter, credential or output, should be included in the output of explain to avoid errors when duplicating the logic for each one.
There was also a copy/paste of the appliesTo logic for ParameterDefinition (our def of a parameter in the porter manifest) that
I updated to implement Scoped so that we can hopefully avoid more problems with this type of check.
What issue does it fix
Closes #1667
Notes for the reviewer
N/A
Checklist