Fix tag detection on azure pipelines #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUILD_SOURCEBRANCH is populated for branches _and_ tags. Oops. This fixes how we use that variable to differentiate between a branch and tag build. I'm not happy with it either... Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
fix-tag-detection
branch
from
13cfb8f to
e41b769
Compare
vdice
approved these changes
Jul 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUILD_SOURCEBRANCH is populated for branches and tags. Oops. This fixes how we use that variable to differentiate between a branch and tag build. This addresses the problem on the last release I did yesterday where the build didn't properly read the tag, and thought it was a branch build when it was a tag build.
I'm not happy with it either...