Print help when no args are passed #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should print help text in the following scenarios: * porter * porter help * porter --help The reason why this isn't happening by default is because our root command implements Run. This allows us to print the version for either * porter --version * porter version There are tests now for all of the behaviors above to catch regressions. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
vdice
approved these changes
Jul 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
We should print help text in the following scenarios:
The reason why this isn't happening by default is because our root command implements Run. This allows us to print the version for either:
There are tests now for all of the behaviors above to catch regressions.
What issue does it fix
Closes #1673
Notes for the reviewer
Put any questions or notes for the reviewer here.
Checklist