Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update credentials.md #1689

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Update credentials.md #1689

merged 1 commit into from
Jul 27, 2021

Conversation

jemgoss
Copy link
Contributor

@jemgoss jemgoss commented Jul 26, 2021

What does this change

Just a quick fix to the doc:
Under CREATE A CREDENTIAL SET...
s/porter parameters generate/porter credentials generate/

@vdice
Copy link
Member

vdice commented Jul 27, 2021

Thanks @jemgoss! When convenient, can you sign the commit on this PR? Check out https://porter.sh/contribute/guide/#signing-your-commits and let me know if I can help. Otherwise, this is ready to go!

s/porter parameters generate/porter credentials generate/

Signed-off-by: Jeremy Goss <jem@goss-family.net>
@jemgoss
Copy link
Contributor Author

jemgoss commented Jul 27, 2021

PR signed. Now I know what to do. Hopefully I can provide some bigger contributions going forward :)

Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jemgoss!

@vdice vdice merged commit 394f7ac into getporter:main Jul 27, 2021
@jemgoss jemgoss deleted the patch-1 branch July 27, 2021 18:30
@carolynvs carolynvs mentioned this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants