docs(code): Introduce copy code feature #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisommore
requested review from
carolynvs,
jeremyrickard and
vdice
as code owners
Signed-off-by: thisisommore <ommore501@gmail.com>
thisisommore
force-pushed
the
thisisommore/introduce-copy-button-1688
branch
from
b96f4d8 to
938440a
Compare
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/with#ambiguity_contra Signed-off-by: thisisommore <ommore501@gmail.com>
|
Some code blocks are not meant to be copy/pasted. For example when we are showing an example command and its output. Those code blocks have the CSS class
|
|
Agreed!, I will make changes and push it. |
Additional changes -Added comments to explain whole code where necessary -Renamed ele to preElement Signed-off-by: thisisommore <ommore501@gmail.com>
thisisommore
force-pushed
the
thisisommore/introduce-copy-button-1688
branch
from
7f6eb05 to
19d6e8c
Compare
carolynvs
approved these changes
Aug 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Adds copy button to every command in docs
Copy button can be used to quickly copy commands which saves time especially when commands are long
What issue does it fix
Closes #1688
Notes for the reviewer
I have not tried to put the copy button to the right of the code since it takes space resulting in reducing the code view area.
The button in the top right looks nicer.
Checklist