Allow repeating install when --force is specified #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
force-install
branch
3 times, most recently
from
f96aa08 to
47d66ae
Compare
When building out a bundle for the first time, or troubleshooting, sometimes it is incredibly helpful to be able to repeat the install action, even when it was successful the first time. For example, I am iterating on the install action for a bundle, adding new steps each time I get the bundle to install successfully. In this case, it makes sense to allow the bundle author to repeat the install action with --force. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
force-install
branch
from
47d66ae to
2331dea
Compare
Clear out old testdata between runs Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
force-install
branch
from
6e2fac2 to
cd96f1c
Compare
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
When building out a bundle for the first time, or troubleshooting,
sometimes it is incredibly helpful to be able to repeat the install
action, even when it was successful the first time.
For example, I am iterating on the install action for a bundle, adding
new steps each time I get the bundle to install successfully. In this
case, it makes sense to allow the bundle author to repeat the install
action with --force.
What issue does it fix
I was getting stuck authoring bundles and realized the restriction I added was ... too restrictive.
Notes for the reviewer
I realize that --force isn't documented this way. I think the --force flag makes sense though for this scenario. It's basically "do everything you can to make this work". 😀
Checklist