Always collect outputs even when bundle fails #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdice
approved these changes
Aug 23, 2021
When a bundle fails, we still need to collect any generated outputs because they may contain state that is needed for the next run. What I am running into is that when I install a bundle that uses terraform, and it fails, the tfstate file output is not persisted, so I can't repeat the install command again. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
graceful-exit
branch
2 times, most recently
from
d4943a2 to
eccc2e2
Compare
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I've rebased to resolve a merge conflict and kicked the integration tests. Will merge when they pass! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
When a bundle fails, we still need to collect any generated outputs because they may contain state that is needed for the next run.
What I am running into is that when I install a bundle that uses terraform, and it fails, the tfstate file output is not persisted, so I can't repeat the install command again.
What issue does it fix
I found this bug and was immediately so enraged that I had to fix it immediately
Notes for the reviewer
N/A
Checklist