Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mage targets #1737

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Aug 24, 2021

What does this change

  • Move mage targets for build, and restarting the registry into mage.
  • Use the new mage targets in our CI builds

What issue does it fix

I needed a few more targets available from mage, and so I've moved over a few more. One day we will be off of make. 😀

Notes for the reviewer

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

@carolynvs
Copy link
Member Author

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs
Copy link
Member Author

/azp run test-porter-release

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

* Clear registry before running tests
* Move build into a mage target
* Update contributing.md with the moved targets

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs marked this pull request as ready for review August 25, 2021 15:11
@carolynvs carolynvs merged commit 9d6be0b into getporter:release/v1 Aug 25, 2021
@carolynvs carolynvs deleted the move-mage-targets branch August 25, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants