Include list of mixins used in porter explain and simplify explain output #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List just the names of the mixins in the output for porter explain. I'm not using the term mixin in the table output because we don't expect consumers of bundles to know what they are. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
As we keep adding more sections to the explain output, these "No x defined" placeholders make the output longer and cluttered. Let's just focus on what's in the bundle. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
print-mixins-used
branch
from
ae2f158 to
b145e52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
List just the names of the mixins in the output for porter explain. I'm not using the term mixin in the table output because we don't expect consumers of bundles to know what they are.
As we keep adding more sections to the explain output, these "No x defined" placeholders make the output longer and cluttered. Let's just focus on what's in the bundle.
What issue does it fix
This is shameless demo driven development. 😝 So you can quickly see “this bundle uses helm and terraform and thankfully isn’t using exec”. My KubeCon talk is about how porter is not only safer than curl | bash, but that it gives you more info. So you can see “oh it only uses stuff that I think are okay” without having to … you know READ the darn thing.
Notes for the reviewer
Cannot be merged until #1739 is merged. You can skip reviewing the first commit.
Checklist