Use official mongodb driver #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
change-mongodb-driver
branch
5 times, most recently
from
298865f to
fecb2f4
Compare
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
I used the mgo driver (because it's easier to use) but it doesn't support the newer version of mongodb (4+) and also doesn't support the newer connection string format used exclusively by mongodb atlas (mongo's cloud offering for mongodb, its freee soooooooooo, we are totes gonna support it). Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
* A couple tests weren't calling teardown * Fix connection leak with the test database plugin * Make timeout configurable so that if someone is on a slow machine, they can wait longer. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
change-mongodb-driver
branch
from
fecb2f4 to
aa00571
Compare
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@vdice Can you take one more look? I found a connection leak when running the tests, so I added 2 more commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
I used the mgo driver (because it's easier to use) but it doesn't support the newer version of mongodb (4+) and also doesn't support the newer connection string format used exclusively by mongodb atlas (mongo's cloud offering for mongodb, its freee 💸 soooooooooo, we are totes gonna support it).
What issue does it fix
Now I can do my kubecon demo using a cloud database that I don't have to pay for or keep updated myself. Huzzah!
Notes for the reviewer
Sorry for not biting the bullet and just using the official driver when I first implemented this. The driver honestly isn't as easy to use but luckily most of the changes necessary are in just a few spots.
Checklist