Make log persistence configurable #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdice
reviewed
Sep 27, 2021
tests/smoke/hello_test.go
Outdated
|
|
||
| test.RequirePorter("upgrade", "mybuns") | ||
| test.RequirePorter("installation", "show", "mybuns") | ||
|
|
||
| test.RequirePorter("uninstall", "mybuns") | ||
| // Check that we can disable logs from persisting | ||
| test.RequirePorter("uninstall", "mybuns", "--persist-logs=false") |
There was a problem hiding this comment.
Oops yeah. I just pushed a fix for the smoke tests. I had originally gone with --persist-logs but that wasn't a good flag name because in general boolean flags are easiest to use when they default to false and you only specify it when you want it to be true.
Add a flag to the bundle actions allowing the user to skip saving a copy of the logs to Porter's datastore. porter install --no-logs Now when they run porter logs -i mybuns, it will return "no logs found". This is useful in cases where the logs are too large to store. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
disable-logs
branch
from
a43d6f2 to
4badbf1
Compare
|
@vdice All fixed, please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Add a flag to the bundle actions allowing the user to skip saving a copy of the logs to Porter's datastore.
Now when they run
porter logs -i mybuns, it will return "no logs found".This is useful in cases where the logs are too large to store.
What issue does it fix
Closes #1778
Notes for the reviewer
I will cherry-pick this into v1 after this is merged.
Checklist