Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync operator with porter v1 #1785

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Conversation

carolynvs
Copy link
Member

What does this change

These are changes necessary to get the Porter Operator updated to work with the latest version of Porter v1

  • Log which config file we loaded, since the operator injects it in non-standard spot.
  • Print the used config on a separate line. If the file didn't have a newline at the end, the logs were continuing on the same line as the config output.
  • Allow specifying some runtime flags (normally specified on porter install) during porter apply: runtime-driver and
    allow-docker-host-access.
  • Log the runtime driver used

What issue does it fix

N/A

Notes for the reviewer

None

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

These are changes necessary to get the Porter Operator updated to work
with the latest version of Porter v1

* Log which config file we loaded, since the operator injects it in
non-standard spot.
* Print the used config on a separate line. If the file didn't have a
newline at the end, the logs were continuing on the same line as the
config output.
* Allow specifying some runtime flags (normally specified on porter
install) during porter apply: runtime-driver and
allow-docker-host-access.
* Use consistent naming for AllowDockerHostAccess. It was confusing that
we used two different terms for it in the code.
* Log the runtime driver used
* Add mage target for building the porter agent and publishing it to the
operator test cluster using the canary-dev tag, e.g.
localhost:5000/porter-agent:canary-dev

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs
Copy link
Member Author

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs carolynvs marked this pull request as ready for review October 1, 2021 14:14
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>

Co-authored-by: Vaughn Dice <vadice@microsoft.com>
@carolynvs carolynvs merged commit 0724be1 into getporter:release/v1 Oct 5, 2021
@carolynvs carolynvs deleted the operator branch October 5, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants