Allow config env vars to be empty #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider an empty environment variable as set, so that you can do things like PORTER_DEFAULT_STORAGE= and have that override what is in the config file Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
fix-empty-config-vars
branch
from
6b2ace9 to
e3f787a
Compare
vdice
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Consider an empty environment variable as set, so that you can do things like
PORTER_DEFAULT_STORAGE=and havethat override what is in the config file.
I am using this in the Porter Operator to be able to switch which storage backend I am using with an environment variable, and not have to edit the file.
What issue does it fix
N/A
Notes for the reviewer
N/A
Checklist