Use plaintext instead of table for human-readable output format. #1803
Conversation
joshuabezaleel
requested review from
carolynvs,
jeremyrickard and
vdice
as code owners
Signed-off-by: joshuabezaleel <joshua.bezaleel@gmail.com>
Signed-off-by: joshuabezaleel <joshua.bezaleel@gmail.com>
Signed-off-by: joshuabezaleel <joshua.bezaleel@gmail.com>
joshuabezaleel
force-pushed
the
rename-table-plaintext
branch
from
e8b07a2 to
ad2bdf7
Compare
| * [Om More](https://github.com/thisisommore) | ||
| * [Joshua Bezaleel Abednego](https://github.com/joshuabezaleel) |
| @@ -98,21 +96,7 @@ func (p *Porter) PrintInstallationRuns(opts RunListOptions) error { | |||
| return printer.PrintYaml(p.Out, displayRuns) | |||
| case printer.FormatPlaintext: | |||
| return printer.PrintPlaintext(p.Out, displayRuns) | |||
| case printer.FormatTable: | |||
There was a problem hiding this comment.
Oh! I just realized that we have a function defined printer.PrintPlaintext that is just totally wrong and we shouldn't be using it.
Can you remove the printer.PrintPlaintext function and then add back this case in the switch statement so that it prints the run properly when Plaintext is the selected format? The current logic that we have here for table is what we want to keep.
| -------------------------------------------------------- | ||
| 1 install 2020-04-18 0001-01-01 succeeded | ||
| 2 uninstall 2020-04-18 0001-01-01 succeeded | ||
| [{1 install map[] 2020-04-18 01:02:03.000000004 +0000 UTC 0001-01-01 00:00:00 +0000 UTC succeeded} {2 uninstall map[] 2020-04-18 01:02:03.000000004 +0000 UTC 0001-01-01 00:00:00 +0000 UTC succeeded}] |
There was a problem hiding this comment.
The output here is why I'm asking for the change above (adding back the original table case statement to that switch statement). As you can see printer.PrintPlaintext just dumps the data.
So the changes to this file should be reverted and then make sure that this test case passes.
Signed-off-by: joshuabezaleel <joshua.bezaleel@gmail.com>
Signed-off-by: joshuabezaleel <joshua.bezaleel@gmail.com>
joshuabezaleel
force-pushed
the
rename-table-plaintext
branch
from
e561735 to
f78410c
Compare
|
@carolynvs PR updated, thank you for the always kind and detailed review Carolyn! 😄 |
What does this change
Use plaintext instead of table for human-readable output format.
What issue does it fix
Closes #1491
Checklist