Improve error message when cnab-to-oci fixes up a bundle #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cnab-to-oci fixes up a bundle after publishing it, if any error occurs we only get a single error message "failed to fixup the image for service InvocationImage" This bumps our cnab-to-oci to use the patch in cnabio/cnab-to-oci#113 so that we get a more detailed error message that indicates the image that failed, and which fixup step. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
bump-cnab-to-oci
branch
from
3446824 to
0f46f3b
Compare
vdice
approved these changes
Nov 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
When cnab-to-oci fixes up a bundle after publishing it, if any error occurs we only get a single error message
"failed to fixup the image for service InvocationImage"
This bumps our cnab-to-oci to use the patch in
cnabio/cnab-to-oci#113
so that we get a more detailed error message that indicates the image that failed, and which fixup step.
What issue does it fix
Incorporates the fix from cnabio/cnab-to-oci#113
Notes for the reviewer
I am referencing a fork of cnab-to-oci that is published in the getporter org because I don't expect the patch to merge quickly.
Checklist