Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default registry to localhost:5000 #1855

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Change default registry to localhost:5000 #1855

merged 2 commits into from
Jan 10, 2022

Conversation

mahendrabishnoi2
Copy link
Contributor

@mahendrabishnoi2 mahendrabishnoi2 commented Jan 8, 2022 •
edited by carolynvs
Loading

What does this change

Change default registry for new bundles from getporter to "localhost:5000"

What issue does it fix

Closes #1758

Notes for the reviewer

  • Changed default registry
  • make test-unit and mage testSmoke passing
  • Verified generated porter.yaml file when running porter create

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

@mahendrabishnoi2
Change default registry where bundle is published
41f2f7d 
Signed-off-by: Mahendra Bishnoi <mahendrabishnoi2@gmail.com>
@mahendrabishnoi2
Update CONTRIBUTORS.md file
93e31d5 
Signed-off-by: Mahendra Bishnoi <mahendrabishnoi2@gmail.com>
carolynvs
carolynvs approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for for the fix! 💯

@carolynvs
Copy link
Member

/azp run porter-integration

@carolynvs carolynvs self-assigned this Jan 10, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs carolynvs changed the title 1758 Change default registry Change default registry to localhost:5000 Jan 10, 2022
@carolynvs carolynvs merged commit 68f0e50 into getporter:release/v1 Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolynvs carolynvs carolynvs approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@vdice vdice Awaiting requested review from vdice

Assignees

@carolynvs carolynvs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahendrabishnoi2 @carolynvs