Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Complete sentence on "manage installation" doc #2028

Conversation

joshuabezaleel
Copy link
Contributor

What does this change

Complete sentence on "Manage Installation" doc, adding "Porter CLI" at the end.
From "Install a bundle using imperative commands with the" to "Install a bundle using imperative commands with the Porter CLI".

image

What issue does it fix

Closes #2027

Notes for the reviewer

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Signed-off-by: joshuabezaleel <joshua.bezaleel@gmail.com>
@joshuabezaleel joshuabezaleel force-pushed the 2027-incomplete-sentence-doc-manage-installation branch from 9de2e08 to b92be41 Compare April 23, 2022 08:54
@joshuabezaleel joshuabezaleel changed the title Complete sentence on "manage installation" doc [Docs] Complete sentence on "manage installation" doc Apr 23, 2022
Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carolynvs carolynvs merged commit b1369e4 into getporter:release/v1 Apr 27, 2022
@joshuabezaleel joshuabezaleel deleted the 2027-incomplete-sentence-doc-manage-installation branch April 27, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants