Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies V2 Playground #2099

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Commits on Feb 9, 2023

  1. Convert a depsv2 porter.yaml into bundle.json

    This adds support for the dependencies-v2 experimental flag when building a bundle.
    
    * Add dependency v2 fields to the porter.yaml manifest
    * Represent v2 deps in the bundle.json
    * Determine which dependency extension is used by a bundle
    * Have separate packages for the dependencies v2 cnab extension, and its implementation
    * Consolidate extensions definition into a single file
    * Match file names to contained structs in pkg/cnab
    
    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    d3d11c9 View commit details
    Browse the repository at this point in the history
  2. Remove name field from CNAB dependency representation in bundle.json

    The name field for a dependency is not in the spec because CNAB represents a dependency as a map entry, keyed by name. We use a name internally just to make things easier while working with dependency entries but they shouldn't be written out with a name field.
    
    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    9b1a5e5 View commit details
    Browse the repository at this point in the history
  3. Consolidate testdata so we don't have a bunch of similar bundles

    mybuns = a test bundle that contains as many features / test cases we can squeeze into a bundle, without making a bunch of paramters required so that it's easy to run. Long term I want to remove dependencies from this bundle though and switch to using a new set of bundles just for dependencies.
    
    myenv = a metabundle that is comprised of its dependencies. Has a deep dependency graph.
    myinfra = a bundle that creates infrastructure and generates outputs that parent bundles would want to consume.
    myapp = a bundle that deploys an application and requires a db connection string
    mydb = a leaf bundle that creates a db and outputs a connection string
    
    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    ad6f58b View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2023

  1. wip: stub structs and logic for a bundle workflow

    * resolve a dependency graph
    * identify the order of execution
    * create new call path to execute bundles from a workflow (i.e. jobs)
    * Add secret strategy for resolving data from the workflow
    * Support workflow wiring
    
    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    
    wip: porter strategy
    
    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    d476874 View commit details
    Browse the repository at this point in the history
  2. wip

    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    8610bfa View commit details
    Browse the repository at this point in the history
  3. wip: test passes with stuff commented out because dry-run prints the …

    …wrong format still
    
    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    701d725 View commit details
    Browse the repository at this point in the history
  4. yes we should inject dependency defs into a bundle

    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    54251e3 View commit details
    Browse the repository at this point in the history
  5. Manually hydrate deps name in cnab representation of depsv2

    This should ideally go into the open PR
    
    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    aae9178 View commit details
    Browse the repository at this point in the history
  6. make vet and lint happy

    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    a9702df View commit details
    Browse the repository at this point in the history
  7. Fix schema test to work with beefier mybuns testdata

    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    1424fad View commit details
    Browse the repository at this point in the history
  8. HACK: DO NOT MERGE: Optionally load bundle dependency.json until we f…

    …igure it out
    
    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    2d33418 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. laptop sync

    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    44f76d7 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. wip: made better testdata but now I want the workflow dump to look right

    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    4e111db View commit details
    Browse the repository at this point in the history
  2. Add DisplayWorkflow structure

    Add a DisplayWorkflow structure that can represent a workflow and also remove non-user settable fields so that we can dump our plans without including status, ids, etc.
    
    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    cdeede0 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. laptop sync

    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    6449cd9 View commit details
    Browse the repository at this point in the history
  2. do not keep without editing

    * hacks to force rebuild test bundles
    * porter secret store isn't implemented. Is that hiding on a branch somewhere?
    
    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    f16161d View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Add imported workflow testdata

    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    74a2381 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. laptop sync

    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    bbfd048 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Fix display workflow tests to use stable data

    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    d95a8f6 View commit details
    Browse the repository at this point in the history
  2. this commit will go away when I rebase on depsv2 because the test dat…

    …a should match then
    
    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    b5988e3 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. wip

    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    4271af3 View commit details
    Browse the repository at this point in the history