Persist run bundle as string #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since bundle has dollar prefixed fields, we can't call mongo's update on it and replace the document (which is what I was trying to do during a repeated migration). I've changed how we store just bundle, so that it's a string field when stored in mongo. We don't query based on run.Bundle so I don't see this as being a large change. It does change the storage schema version for installations though. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Now that we have display structs for all of our storage documents these tags are misleading (they aren't used) so I'm removing them. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
VinozzZ
reviewed
Jun 28, 2022
VinozzZ
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Since bundle has dollar prefixed fields, we can't call mongo's update on it and replace the document (which is what I was trying to do during a repeated migration). I've changed how we store just bundle, so that it's a string field when stored in mongo. We don't query based on run.Bundle so I don't see this as being a large change. It does change the storage schema version for installations though.
This change required updating the schemaVersion for Installations to 1.0.2 because it changes the database schema in an incompatible way. It's annoying that we have the db schema tied to the schemaVersion on the input documents (Installation/PS/CS) but at this point I don't see the value in trying to change that before 1.0 and we can revisit for v2.
I also noticed that we were still setting tags for yaml/toml on our storage structs which isn't used now that we have display structs for everything. So when I was editing the Run.Bundle tag, I cleaned up all the storage doc tags so that it's clear what is still used.
What issue does it fix
Closes #2196
Notes for the reviewer
This is split off from #2150 so that the other PR is just migration stuff, and not the bugs found along the way.
Checklist
Reviewer Checklist