Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directory Param feature #2251

Open
wants to merge 13 commits into
base: release/v1
Choose a base branch
from
Open

Directory Param feature #2251

wants to merge 13 commits into from

Commits on Jul 15, 2022

  1. Make the bundle user details global to the build package. Required if… 

    … we allow subsituting build variables in parameters. If we choose not, we can revert this easily.
    Rich Baird authored and Rich Baird committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    d66127b View commit details
    Browse the repository at this point in the history

  2. Revert "Make the bundle user details global to the build package. Req… 

    …uired if we allow subsituting build variables in parameters. If we choose not, we can revert this easily."

This reverts commit d66127b.
    Rich Baird authored and Rich Baird committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    d873618 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. Make the bundle user details global to the build package. Required if… 

    … we allow subsituting build variables in parameters. If we choose not, we can revert this easily.

Signed-off-by: Rich Baird <Rich@rbaird.me>
    Rich Baird authored and Rich Baird committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    a87e7de View commit details
    Browse the repository at this point in the history

  2. Revert "Make the bundle user details global to the build package. Req… 

    …uired if we allow subsituting build variables in parameters. If we choose not, we can revert this easily."

This reverts commit d66127b.

Signed-off-by: Rich Baird <Rich@rbaird.me>
    Rich Baird authored and Rich Baird committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    a744f47 View commit details
    Browse the repository at this point in the history

  3. Create a new parameter type, and refactor parameter type checking int… 

    …o its own function to facilitate additional growth.

Signed-off-by: Rich Baird <Rich@rbaird.me>
    Rich Baird authored and Rich Baird committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    f26bba5 View commit details
    Browse the repository at this point in the history

  4. add comments to the helper functions 

    Signed-off-by: Rich Baird <Rich@rbaird.me>
    Rich Baird authored and Rich Baird committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    ee52834 View commit details
    Browse the repository at this point in the history

  5. directory parameter added. TODO: Make customizable 

    Signed-off-by: Rich Baird <Rich@rbaird.me>
    Rich Baird authored and Rich Baird committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    b1b664e View commit details
    Browse the repository at this point in the history

  6. Fix the logic of IsDirSource to prevent duplicate mount errors 

    Signed-off-by: Rich Baird <Rich@rbaird.me>
    Rich Baird authored and Rich Baird committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    92e5499 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. Merge branch 'release/v1' of https://github.com/getporter/porter into… 

    … release/v1
    Rich Baird authored and Rich Baird committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    52ab946 View commit details
    Browse the repository at this point in the history

  2. merge 1.0.0

    Rich Baird authored and Rich Baird committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    d8448e2 View commit details
    Browse the repository at this point in the history

  3. make sure it builds

    Rich Baird authored and Rich Baird committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    c04705e View commit details
    Browse the repository at this point in the history

  4. merged parameters.go incorrectly, so fixed it

    Rich Baird authored and Rich Baird committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    6099810 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. Cherry pick execute callback in closure

    Rich Baird authored and Rich Baird committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    2a2ada8 View commit details
    Browse the repository at this point in the history