-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install multiple plugins by passing in a file argument to porter plugins install #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c18d7a2
to
feca084
Compare
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
feca084
to
b36ede4
Compare
sgettys
reviewed
Jan 5, 2023
sgettys
reviewed
Jan 5, 2023
sgettys
reviewed
Jan 5, 2023
sgettys
reviewed
Jan 5, 2023
sgettys
reviewed
Jan 5, 2023
Need docs/schema around new plugins config file format |
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
sgettys
approved these changes
Jan 12, 2023
4 tasks
bdegeeter
pushed a commit
to bdegeeter/porter
that referenced
this pull request
May 11, 2023
…ins install (getporter#2504) Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
This PR adds a new
--file
flag to theporter plugins install
command.This allows users to define multiple plugins in a file and install them with a single porter command.
What issue does it fix
Closes #2491
Notes for the reviewer
Maybe we need to define a schema for this plugins config file?
Checklist
Reviewer Checklist