Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install multiple plugins by passing in a file argument to porter plugins install #2504

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Dec 28, 2022

What does this change

This PR adds a new --file flag to the porter plugins install command.
This allows users to define multiple plugins in a file and install them with a single porter command.

What issue does it fix

Closes #2491

Notes for the reviewer

Maybe we need to define a schema for this plugins config file?

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@VinozzZ VinozzZ force-pushed the plugins-install-file branch 3 times, most recently from c18d7a2 to feca084 Compare January 4, 2023 20:08
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
@VinozzZ VinozzZ force-pushed the plugins-install-file branch from feca084 to b36ede4 Compare January 4, 2023 20:17
@VinozzZ VinozzZ marked this pull request as ready for review January 4, 2023 20:17
@VinozzZ VinozzZ requested review from bdegeeter and sgettys January 5, 2023 17:21
pkg/plugins/install.go Outdated Show resolved Hide resolved
pkg/plugins/install.go Outdated Show resolved Hide resolved
pkg/porter/plugins.go Outdated Show resolved Hide resolved
@sgettys
Copy link
Contributor

sgettys commented Jan 5, 2023

Need docs/schema around new plugins config file format

Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
@VinozzZ VinozzZ requested a review from sgettys January 9, 2023 21:46
@VinozzZ VinozzZ merged commit 569394a into getporter:main Jan 12, 2023
@VinozzZ VinozzZ deleted the plugins-install-file branch January 12, 2023 17:22
bdegeeter pushed a commit to bdegeeter/porter that referenced this pull request May 11, 2023
…ins install (getporter#2504)

Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to install multiple plugins
2 participants