Fix support for numeric types #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I updated the canonical json library used by cnab-go, I missed that cnab-to-oci also used the one without support for numeric types. I have updated Porter with a regression test for numeric types (just building a bundle with it isn't enough, we need to push it too which exercises the fix in cnab-to-oci). For now we'll stay on a patched cnab-to-oci until the patch is merged and a new release of cnab-to-oci is available. This fixes the following error when pushing a bundle that uses numeric types, such as setting the default value for a paramter to 0.5 ``` $ porter publish reference not found (localhost:5000/porter-hello:v0.1.0) Pushing bundle image... The push refers to repository [localhost:5000/porter-hello] ... 0fd880641d89: Pushed 9d0460f30cfd: Pushed 76dda007b025: Pushed porter-37da5464f8517662657529ad34851db9: digest: sha256:d53641f601988f8894ebc681bcb277624db45e328f547054401d2de994e2ab1e size: 2412 Rewriting CNAB bundle.json... Starting to copy image localhost:5000/porter-hello@sha256:d53641f601988f8894ebc681bcb277624db45e328f547054401d2de994e2ab1e... Completed image localhost:5000/porter-hello@sha256:d53641f601988f8894ebc681bcb277624db45e328f547054401d2de994e2ab1e copy error pushing the bundle to localhost:5000/porter-hello:v0.1.0: json: unsupported value: 0.5 ``` Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
requested review from
VinozzZ,
sgettys and
bdegeeter
as code owners
sgettys
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
When I updated the canonical json library used by cnab-go, I missed that cnab-to-oci also used the one without support for numeric types. I have updated Porter with a regression test for numeric types Just building a bundle with it isn't enough as we already had tests for that in the cnab config adapter tests. We needed to push it too which exercises the fix in cnab-to-oci, so I added this to the mybuns bundle used in our smoke tests. For now we'll stay on a patched cnab-to-oci until the patch is merged and a new release of cnab-to-oci is available.
This fixes the following error when pushing a bundle that uses numeric types, such as setting the default value for a parameter to 0.5
What issue does it fix
This addresses the issue raised in cnabio/cnab-to-oci#131
Notes for the reviewer
NA
Checklist
Reviewer Checklist