Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve trace data when reconciling an installation #2564

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Improve trace data when reconciling an installation #2564

merged 3 commits into from
Feb 13, 2023

Conversation

carolynvs
Copy link
Member

What does this change

  • Fixes a nested span problem in Porter.InstallationApply
  • Adds the request to the traces when communicating with the plugins. In a few cases, I also include a count of the results returned.

What issue does it fix

These were changes I made while debugging another feature and they seemed good to just commit and keep around.

Notes for the reviewer

N/A

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@carolynvs
Fix missing call to EndSpan for Reconcile
4003aae 
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs
Include storage protocol request in tracing
f8e94d8 
When we make a call to a storage plugin, include the options sent so that it's possible to tell what the call was for. I have also included the count of the results for relevant calls (Find/Count) to assist with troubleshooting.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs
Include secret protocol request in traces
bef1c1a 
When we make a call to resolve or create a secret from a plugin, note the key name (e.g. secret, env, path) and the key value (the name of the value to resolve).

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs marked this pull request as ready for review February 13, 2023 19:28
VinozzZ
VinozzZ approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@carolynvs carolynvs merged commit b712702 into getporter:main Feb 13, 2023
@carolynvs carolynvs deleted the reconcile-tracing branch February 13, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinozzZ VinozzZ VinozzZ approved these changes

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carolynvs @VinozzZ